[homekit] Fix invertedness of GarageDoorOpener characteristics #17181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In openhab#17137, CurrentDoorState and TargetDoorState were moved from being part of the accessory itself, to using the CharacteristicFactory, but they lost the flag that default-inverts them. So make sure to pass that flag in the new location that the mapping is created. Signed-off-by: Cody Cutrer <cody@cutrer.us>
jlaur
added
bug
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
…ab#17181) In openhab#17137, CurrentDoorState and TargetDoorState were moved from being part of the accessory itself, to using the CharacteristicFactory, but they lost the flag that default-inverts them. So make sure to pass that flag in the new location that the mapping is created. Signed-off-by: Cody Cutrer <cody@cutrer.us>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…ab#17181) In openhab#17137, CurrentDoorState and TargetDoorState were moved from being part of the accessory itself, to using the CharacteristicFactory, but they lost the flag that default-inverts them. So make sure to pass that flag in the new location that the mapping is created. Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…ab#17181) In openhab#17137, CurrentDoorState and TargetDoorState were moved from being part of the accessory itself, to using the CharacteristicFactory, but they lost the flag that default-inverts them. So make sure to pass that flag in the new location that the mapping is created. Signed-off-by: Cody Cutrer <cody@cutrer.us>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…ab#17181) In openhab#17137, CurrentDoorState and TargetDoorState were moved from being part of the accessory itself, to using the CharacteristicFactory, but they lost the flag that default-inverts them. So make sure to pass that flag in the new location that the mapping is created. Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17137, CurrentDoorState and TargetDoorState were moved from being part of the accessory itself, to using the CharacteristicFactory, but they lost the flag that default-inverts them. So make sure to pass that flag in the new location that the mapping is created.